[feature] Setup simple player movement controller for 2D environment

[Yonodactyl]

While we work out the additional details on the game concept, just to continue the development of a community game, we will need a basic character controller (which extends CharacterBody2D).

[ryankmims]

https://github.com/Godot-Community-Games-Org/game1/tree/feature-player-controller-base

I've created this feature branch here and have finished the player movement controller base. I'm waiting for testing and potentially some feedback about folder structure

[Dragon20C]

@ryankmims, It simple enough, and also since its top down make sure its set to floating instead of grounded on the motion mode on the characterbody2d.

[ryankmims]

@ryankmims, It simple enough, and also since its top down make sure its set to floating instead of grounded on the motion mode on the characterbody2d.

Thanks for catching that. Just changed it

[Dragon20C]

hello @ryankmims I would like to commit a camera shaker to the player controller branch but I am met with "Unable to push to 'origin' - unexpected http status code: 403"(I am using a git client) but this is my first time creating in a group, and I would love to add some code to the branch project, how would I do it the right way?

[ryankmims]

@Dragon20C 403 usually means you don't have access. Are you using the right username that you were given access with? You might need to ask GodotCommunityGamesFounder to be added to the repo

[StrawberrySmoothieDev]

hello @ryankmims I would like to commit a camera shaker to the player controller branch but I am met with "Unable to push to 'origin' - unexpected http status code: 403"(I am using a git client) but this is my first time creating in a group, and I would love to add some code to the branch project, how would I do it the right way?

Please do not commit directly to the repo. Instead make a PR so the code can be reviewed. Furthermore, we're avoiding making PRs outside of low-level boilerplate while we set baselines and rules. Thanks!

[Dragon20C]

Thanks for the reply, so of course I should make a pr first would I need to fork the repo to make a pull request or should I make another branch with my additions and request a pr that way?

[ryankmims]

In the future, if you want to add to a branch, fetch it, pull the most recent code, create a new branch off of that one. Do your changes, commit and push, and then do your merge request into that branch.

At least that is my understanding of the workflow @StrawberrySmoothieDev can correct me if I'm wrong

[StrawberrySmoothieDev]

In the future, if you want to add to a branch, fetch it, pull the most recent code, create a new branch off of that one. Do your changes, commit and push, and then do your merge request into that branch.

At least that is my understanding of the workflow @StrawberrySmoothieDev can correct me if I'm wrong

It's more like create a branch, make your code, and make a pull request to merge it to the main branch. That may be what you're saying and I'm just reading it wrong but idk. Either way, just allow for code review.

[ryankmims]

In the future, if you want to add to a branch, fetch it, pull the most recent code, create a new branch off of that one. Do your changes, commit and push, and then do your merge request into that branch. At least that is my understanding of the workflow @StrawberrySmoothieDev can correct me if I'm wrong

It's more like create a branch, make your code, and make a pull request to merge it to the main branch. That may be what you're saying and I'm just reading it wrong but idk. Either way, just allow for code review.

If you're making changes to a feature branch that hasn't been merged yet though, I think it would be better to just go into the feature branch, and branch off of that

[StrawberrySmoothieDev]

Ah my bad, misread it. Generally yep :3