search

GodotECS / godex

Godex is a Godot Engine ECS library.
MIT License
1.2k stars 68 forks source link

Change PROPERTY_USAGE_NOEDITOR to PROPERTY_USAGE_NO_EDITOR #274

Closed lewiji closed 2 years ago

lewiji commented 2 years ago

PROPERTY_USAGE_NOEDITOR has been recently renamed to PROPERTY_USAGE_NO_EDITOR on master, for consistency with other constants.

See: https://github.com/godotengine/godot/commit/c012fbc8b235b86ed70c501834825d91292f8811

AndreaCatania commented 2 years ago

Thanks for the contribution!

AndreaCatania commented 2 years ago

The CI will not pass because it's necessary to update the Godot version here https://github.com/GodotECS/godot/tree/godex_version. I'll do it later today or in the next days. I'll keep you in loop.

lewiji commented 2 years ago

No problem! Well, it's a good idea to hold off maybe, unless you have time to test stuff thoroughly. I made the change while I was compiling latest from master earlier (a3850ba specifically), and it's been quite buggy so far, strange editor behaviour where the Godex UI and some Godot inspector fields seem to lose signal connections intermittently, or at least UI elements stop responding to input, but without errors. However, I'm also trying to get mono working with this build, and I'm not sure if it's the commit I'm on or the mono build interfering. It's probably both! I'll try it without mono enabled if I get a chance.

AndreaCatania commented 2 years ago

Thanks :)