search

GodotECS / godex

Godex is a Godot Engine ECS library.
MIT License
1.2k stars 68 forks source link

Fix build error issue #293 #294

Closed miroklarin closed 2 years ago

miroklarin commented 2 years ago

Fix build error, missing as_const Fix few typos

miroklarin commented 2 years ago

Thanks a lot for the PR, it looks nice just a small change.

Also, I would like to try including this header #include <type_traits> instead, as is_const is defined there https://en.cppreference.com/w/cpp/header/type_traits

Can you please try that please?

it is not about is_const, it is about as_const

https://en.cppreference.com/w/cpp/utility/as_const

AndreaCatania commented 2 years ago

You right! I saw you fixed the style, thx! I wonder why you switched from: #include <utility> to #include "utility" it seems like the first one looks more correct?

AndreaCatania commented 2 years ago

Now the static check is complaining about the fact that the include should be the last one. We have a CLang formatter config that sorts the includes alphabetically. If you use it, it will just sort the includes for you, I suggest to change the include back to #include <utility> before sorting it using CLang formatter.