GodotECS / godex

Godex is a Godot Engine ECS library.
MIT License
1.2k stars 68 forks source link

fix compilation for current godot #297

Closed tpltnt closed 2 years ago

tpltnt commented 2 years ago

Hi there,

the current godex master (1d2e23a42ed57e3017f3efb6a8fafc8912141b08) branch does not compile with current godot master (8d15814e6a211646a04478978224fd1af41a75cc). Example error message:

[Initial build] Compiling /godex/modules/godot/nodes/ecs_utilities.cpp ...
/godex/modules/godot/editor_plugins/editor_world_ecs.cpp: In member function 'void EditorWorldECS::add_error(const String&)':
/godex/modules/godot/editor_plugins/editor_world_ecs.cpp:1265:39: error: 'Label::AutowrapMode' has not been declared
 1265 |         lbl->set_autowrap_mode(Label::AutowrapMode::AUTOWRAP_WORD_SMART);
      |                                       ^~~~~~~~~~~~
/godex/modules/godot/editor_plugins/editor_world_ecs.cpp: In member function 'void EditorWorldECS::add_warning(const String&)':
/godex/modules/godot/editor_plugins/editor_world_ecs.cpp:1273:39: error: 'Label::AutowrapMode' has not been declared
 1273 |         lbl->set_autowrap_mode(Label::AutowrapMode::AUTOWRAP_WORD_SMART);
      |                                       ^~~~~~~~~~~~
scons: *** [/godex/modules/godot/editor_plugins/editor_world_ecs.linuxbsd.opt.tools.64.o] Error 1
scons: building terminated because of errors.
[Time elapsed: 00:00:32.660]

This patch fixes the compilation by adjusting two lines.

Cheers, tpltnt

AndreaCatania commented 2 years ago

@tpltnt Before merging this I'll need to update the Godot build. I'll do that in the next days and merge this afterward, thx alot!!

AndreaCatania commented 2 years ago

Thx!