GodotNuts / GodotFirebase

Implementations of Firebase for Godot using GDScript
MIT License
554 stars 79 forks source link

Add underscore before set_config in dynamic links #125

Closed timjrobinson closed 3 years ago

timjrobinson commented 3 years ago

In https://github.com/GodotNuts/GodotFirebase/commit/b617ce35a21c4e31946156607722e42819ccdad6 in #120 DynamicLinks._set_config() is called, but this function doesn't have an underscore before it, causing this plugin to crash upon launch.

Added the underscore so it doesn't crash.

BearDooks commented 3 years ago

@timjrobinson thanks for this! I am.checking with the team now. There is another PR open to fix some issues, and the underscore fix is in there.

If that one is not ready I will merge your PR.

Chuck