Closed timjrobinson closed 3 years ago
Ok I fixed the Firestore example not working by fixing the callback, the get
and add
signals were reversed.
You also need to create the collection first or it gives an authentication error, not sure if it's possible to create the initial collection with with this plugin or not.
Here, for example: https://github.com/GodotNuts/FirebaseDemo-Chat
Is there a way these could be added as automatically run integration tests? I'd like something to check basic flows work after changes.
Hm. That's a really good question. I'll look again to see if that's possible, but if it's a true integration test, I can't have that hitting my Firebase instance (which I assume would be needed), and I'm not about to let it hit anyone else's. I wonder if there's a Github Action that allows you to download the Firebase Simulator and run tests against it instead of live.
Alright, after talking to the team about this, we think it's worth elevating to its own demo for game-hosting with Firebase. If I create a new repo for what, would you care to join the team and begin working on the demo so it's a bit more fully-fleshed-out? You wouldn't also have to join the team, but you've contributed so much, I think we'd be happy to have you.
I like the idea of a Github Action that can spin up the Firebase Simulator and run it with that. I could do a demo eventually but probably don't have time right now as I'm trying to make a game a week. I'm using this package for https://puzzop.com games and I stream all development at https://twitch.tv/puzzop so you can see me struggling with the plugin there :p
Geez! If you'd told me ORIGINALLY, I'd have come watched your stream much earlier and offered help. :D That's awesome! Really good to see people using it. Regarding GitHub Actions, it looks like in theory it should be possible, but I have not yet figured out a good way to actually do it. I'm going to see if I can talk to someone from the Firebase team about it directly, as it's probably easier to get info that way than hoping #AskFirebase answers something. :P
I'm going to go ahead and close this. You can open an issue if you need us to create a demo project for which you can add this code (I'm happy to do it, just for tracking purposes I'd like to have the issue please).
/rooms
with a room code, and then listens for updates.rooms
collection in Firestore, then polls for updates on 1s interval (as there is currently no way to listen for updates with Firestore). Therooms
collection needs to be created first or it crashes with an Authentication Error (this should also be handled gracefully).These are examples to demonstrate #126
Both these examples should be working but aren't since the refactoring today. I'd like to add these so they can be used as test cases to test against when releasing new changes to GodotFirebase. As well as a demo for new users to get started with the plugin.