GodotNuts / GodotFirebase

Implementations of Firebase for Godot using GDScript
MIT License
532 stars 76 forks source link

Add Database and Firestore examples #127

Closed timjrobinson closed 3 years ago

timjrobinson commented 3 years ago

These are examples to demonstrate #126

Both these examples should be working but aren't since the refactoring today. I'd like to add these so they can be used as test cases to test against when releasing new changes to GodotFirebase. As well as a demo for new users to get started with the plugin.

timjrobinson commented 3 years ago

Ok I fixed the Firestore example not working by fixing the callback, the get and add signals were reversed.

You also need to create the collection first or it gives an authentication error, not sure if it's possible to create the initial collection with with this plugin or not.

WolfgangSenff commented 3 years ago

Here, for example: https://github.com/GodotNuts/FirebaseDemo-Chat

timjrobinson commented 3 years ago

Is there a way these could be added as automatically run integration tests? I'd like something to check basic flows work after changes.

WolfgangSenff commented 3 years ago

Hm. That's a really good question. I'll look again to see if that's possible, but if it's a true integration test, I can't have that hitting my Firebase instance (which I assume would be needed), and I'm not about to let it hit anyone else's. I wonder if there's a Github Action that allows you to download the Firebase Simulator and run tests against it instead of live.

WolfgangSenff commented 3 years ago

Alright, after talking to the team about this, we think it's worth elevating to its own demo for game-hosting with Firebase. If I create a new repo for what, would you care to join the team and begin working on the demo so it's a bit more fully-fleshed-out? You wouldn't also have to join the team, but you've contributed so much, I think we'd be happy to have you.

timjrobinson commented 3 years ago

I like the idea of a Github Action that can spin up the Firebase Simulator and run it with that. I could do a demo eventually but probably don't have time right now as I'm trying to make a game a week. I'm using this package for https://puzzop.com games and I stream all development at https://twitch.tv/puzzop so you can see me struggling with the plugin there :p

WolfgangSenff commented 3 years ago

Geez! If you'd told me ORIGINALLY, I'd have come watched your stream much earlier and offered help. :D That's awesome! Really good to see people using it. Regarding GitHub Actions, it looks like in theory it should be possible, but I have not yet figured out a good way to actually do it. I'm going to see if I can talk to someone from the Firebase team about it directly, as it's probably easier to get info that way than hoping #AskFirebase answers something. :P

WolfgangSenff commented 3 years ago

I'm going to go ahead and close this. You can open an issue if you need us to create a demo project for which you can add this code (I'm happy to do it, just for tracking purposes I'd like to have the issue please).