[BUG]Request Query gives unformatted documents

GodotNuts / GodotFirebase

Implementations of Firebase for Godot using GDScript

MIT License

554 stars 79 forks source link

[BUG]Request Query gives unformatted documents #199

Closed Zarasan closed 3 years ago

Zarasan commented 3 years ago

Describe the bug Query gives unformatted documents

To Reproduce Query a document

Expected behavior It should give formatted Firebase Documents

Environment:

OS: Windows 10

Additional context My fix:

WolfgangSenff commented 3 years ago

Hm. So this is now returning an array instead of the document directly?

Zarasan commented 3 years ago

It gives me an array like this: [ document:{createTime:2021-05-24T13:47:36.525224Z, fields:{CountryCode:{stringValue:33}, FirstName:{stringValue:Aaron}, LastName:{stringValue:Asmith}, Mail:{stringValue:user1@qwerty.com}, MoodRequested:{booleanValue:False}, Organization:{stringValue:QWERTY}, PhoneNumber:{stringValue:123}, Points:{integerValue:20}, Role:{stringValue:User}}, name:'redacted', updateTime:2021-05-24T14:38:03.251779Z}, readTime:2021-05-24T18:36:06.858684Z}]

WolfgangSenff commented 3 years ago

Okay. I'm a little worried this could break backward compatibility, if people are using it and not expecting an array like that to come back, but instead a dictionary. Let me confer with the team to make sure I'm not missing something.

Zarasan commented 3 years ago

You can close this its no problem I just share what I have encountered

WolfgangSenff commented 3 years ago

Oh, it's probably good and I'm probably just missing stuff! I'd rather have the code if people are running into issues with it, and you are good people. :)