iOS Fix and In-App Google Authentication with iOS Plugin

GodotNuts / GodotFirebase

Implementations of Firebase for Godot using GDScript

MIT License

530 stars 76 forks source link

iOS Fix and In-App Google Authentication with iOS Plugin #296

Closed Nickfredy closed 2 years ago

Nickfredy commented 2 years ago

There's multiple ways to solve this issue - just put this in for review.

Nickfredy commented 2 years ago

I've just realized I've added everything to the same PR. This includes the ios plugin for inapp. If I need to separate out the PRs let me know - if you just want the ' ' -> '%20' fix in auth.gd. I'm assuming there's better ways to integrate with the plugin and definitely am open to ideas and suggestions.

fenix-hub commented 2 years ago

@Nickfredy can this one be dropped in favour of #297 ?

Nickfredy commented 2 years ago

@Nickfredy can this one be dropped in favour of #297 ?

I kept this one here in case a merge for the iOS fix was needed quickly, but I think it makes sense to close and wait for dev/oauth-provider to be merged.