GodotNuts / GodotFirebase

Implementations of Firebase for Godot using GDScript
MIT License
530 stars 76 forks source link

[BUG] Docs: missing parameter for login_with_oauth in wiki #326

Closed jlundan closed 1 year ago

jlundan commented 1 year ago

Describe the bug The wiki mentions that we should call

Firebase.Auth.login_with_oauth(oath_token)

when we login with OAuth manually. However, the code requires additional provider: AuthProvider argument for the function call:

func login_with_oauth(_token: String, provider: AuthProvider) -> void:

It seems that the second argument is missing from the wiki.

BearDooks commented 1 year ago

@jlundan thanks for finding this. I am going to be combing the wiki next week and will make sure to add this change to it. I will let you know when it is updated

lfkdev commented 1 year ago

Did it like this now:

var google_provider = get_GoogleProvider()
login_with_oauth(token, google_provider)

Which probably isn't the optimal way, but works for me until the docs are fixed

WolfgangSenff commented 1 year ago

This has been fixed and updated. Several examples did have the correct way to handle it, but some did not.