GodotNuts / GodotFirebase

Implementations of Firebase for Godot using GDScript

MIT License

530 stars 76 forks source link

Fix #349 FirestoreQuery.select with array as parameter results in 400 #350

Closed tzrot-jed closed 3 months ago

tzrot-jed commented 1 year ago

String values seem to be passed by value rather than reference even though arrays are passed by reference. Added a local array and re-populated it to fix

The relevant issue number, if applicable.

349

Any new features that have been added

Any relevant tests that have been run Manually tested for expected behavior No relevant test have been run or written

WolfgangSenff commented 3 months ago

Since I haven't heard back from you here, and since I've made an absolutely massive update to the library that in theory should fix this at least in 4.x, I believe I will go ahead and close this for now, but thank you for submitting it originally! If the referenced issue is still an issue in 3.x, I will see if I can find a way to implement my refactor from the 4.x branch in 3.x without losing my mind, which in theory should also just fix the above.