search

GodotNuts / GodotFirebase

Implementations of Firebase for Godot using GDScript
MIT License
517 stars 74 forks source link

[BUG] Godot won't include .env file while exporting the project #370

Closed zimlewis closed 6 months ago

zimlewis commented 7 months ago

Describe the bug Godot isn't able to include .env file while exporting anymore

To Reproduce I just casually export my godot project with firebase addons and when I tried to use my authentication it returned a 403 error: the request is missing a valid api key

Expected behavior The authentication works well in my the editor

Screenshots image image

Environment:

fenix-hub commented 7 months ago

Make sure to follow our wiki when exporting your projects with Firebase. The *.env file should be manually added in the list of exported resources.

WolfgangSenff commented 7 months ago

Make sure to follow our wiki when exporting your projects with Firebase. The *.env file should be manually added in the list of exported resources.

Apparently that doesn't work - the rules of Godot are such that it won't include anything that starts with just a period. I'm not sure if the * makes a difference - it's possible, but I got the impression it didn't.

2d-Peasant commented 7 months ago

Make sure to follow our wiki when exporting your projects with Firebase. The *.env file should be manually added in the list of exported resources.

Apparently that doesn't work - the rules of Godot are such that it won't include anything that starts with just a period. I'm not sure if the * makes a difference - it's possible, but I got the impression it didn't.

I tested it in my project, with both "*" and without it. For android export (godot3.5) it works only if it's included. I didn't test it in other exports.

Btw it's irrelevant to this topic, nevertheless i would like to ask when the "once" feature would be added to v3.5 as well :P thanks!

WolfgangSenff commented 7 months ago

Make sure to follow our wiki when exporting your projects with Firebase. The *.env file should be manually added in the list of exported resources.

Apparently that doesn't work - the rules of Godot are such that it won't include anything that starts with just a period. I'm not sure if the * makes a difference - it's possible, but I got the impression it didn't.

I tested it in my project, with both "" and without it. For android export (godot3.5) it works only if "" included. I didn't test it in other exports.

Btw it's irrelevant to this topic, nevertheless i would like to ask when the "once" feature would be added to v3.5 as well :P thanks!

That is already added, though not to 3.5 yet, has to wait until this weekend.

2d-Peasant commented 7 months ago

That is already added, though not to 3.5 yet, has to wait until this weekend.

Thanks for the update!

WolfgangSenff commented 7 months ago

@zimlewis - can you test this using *.env as the export value? If that works, then I can close this and just update the wiki.

2d-Peasant commented 6 months ago

I guess he is away, tho i tried it on windows 10 OS and it worked there as well, just so as a note.

Anyway, have u got time for a possible 3.5 update?

WolfgangSenff commented 6 months ago

At the moment, no - work is tight right now. It's not a difficult change though, if you want to just look at what I did and do it locally for yourself in 3.5, or if you want to open a PR for it - would be much appreciated!