search

GodotNuts / GodotFirebase

Implementations of Firebase for Godot using GDScript
MIT License
541 stars 77 forks source link

Fix for #372 delete_document error #373

Closed xzirox closed 9 months ago

xzirox commented 9 months ago

Fixed by adding a bool parameter to the _on_delete_document function in firestore_collection.gd

xzirox commented 9 months ago

Does this not require updating wherever it's called as well?

No, because the delete_document signal in firestore_task.gd already emits the boolean as a parameter to the signal.

WolfgangSenff commented 9 months ago

Ahh, interesting, okay. Is it emitted that way everywhere? Or is that the only place?

xzirox commented 9 months ago

Ahh, interesting, okay. Is it emitted that way everywhere? Or is that the only place?

That's the only place that emits the original signal that firestore_collection.gd hooks into.

WolfgangSenff commented 9 months ago

Alright, sounds good then! Thanks!