search

GodotNuts / GodotFirebase

Implementations of Firebase for Godot using GDScript
MIT License
517 stars 74 forks source link

Godot 4.x "Get a Document" example is broken and fails. #392

Closed mroberti closed 3 months ago

mroberti commented 3 months ago

This current documentation under the Get a Document link fails: https://github.com/GodotNuts/GodotFirebase/wiki/Firestore#get-a-document

Current:

var collection: FirestoreCollection = Firebase.Firestore.collection(COLLECTION_ID)
var document_task: FirestoreTask = collection.get(DOCUMENT_ID)
var document: FirestoreDocument = yield(document_task, "get_document")

Proposed fix:

  var collection: FirestoreCollection = Firebase.Firestore.collection(COLLECTION_ID)
  var document_task: FirestoreTask = collection.get_doc(DOCUMENT_ID)
  await document_task.task_finished
  var document: FirestoreDocument = document_task.document
WolfgangSenff commented 3 months ago

Fixed with a small update to the documentation. Thanks!