GodotNuts / GodotFirebase

Implementations of Firebase for Godot using GDScript
MIT License
553 stars 79 forks source link

[BUG] Functions URL is not taking arguments into account #422

Open LazyDridri opened 3 months ago

LazyDridri commented 3 months ago

Description Calling cloud functions is not taking parameters passed through params Dictionary

Location (functions/functions.gd : execute() methods ` var url : String = _base_url + ("/" if not _base_url.ends_with("/") else "") + function function_task._url = url

if not params.empty():
    url += "?"
    for key in params.keys():
        url += key + "=" + params[key] + "&"

`

Solution Replace "url" by "function_task._url" when applying parameters

WolfgangSenff commented 3 months ago

Huh, weird. Appreciate the report! Do you want to contribute back to the project and open a PR for this change? Shouldn't be tough I imagine. Just make sure to fork the repo and then make your branch, fix it, make the PR targeting whatever branch you're fixing it on, and I'll merge it.