GodotNuts / GodotFirebase

Implementations of Firebase for Godot using GDScript
MIT License
554 stars 79 forks source link

New Firebase auth features #57

Closed BearDooks closed 3 years ago

BearDooks commented 3 years ago

This change focuses on adding some new Firebase Auth features that were missing. New features added include

lukehollenback commented 3 years ago

Have to make sure you set is_busy to true before you make every request.

Note that you could bake this into the _is_ready() method that I proposed in my review so you don't have duplicate code.

WolfgangSenff commented 3 years ago

Have to make sure you set is_busy to true before you make every request.

Note that you could bake this into the _is_ready() method that I proposed in my review so you don't have duplicate code.

I'd be okay with that, though I'd prefer the shorter: return not is_busy for the end. Not a big deal either way to me.