Before this PR, each authorization function implemented by the Authorization module @Firebase.Auth would emit the login_succeeded signal upon successful sign-up and sign-in.
With this PR, two different signals will be now emitted:
signup_succeeded called upon successful signup_with_email_and_passwrd() and login_anonymous() (compliant to the identitytoolkit#SignupNewUserResponse response from Firebase)
login_succeeded called upon successful login_with_email_and_password() and login_with_oauth() (compliant to identitytoolkit#VerifyPasswordResponse and identitytoolkit#VerifyAssertionResponse responses from Firebase)
In this way, a client-side logic to differentiate sign-up from sign-in would be easier to implement.
Also, this change won't force users to change their signal connection logics: it is much more easier to connect two different signals (login_succeeded and signup_succeeded) to the same function (example _on_login_signup_succeeded()) rather than connecting the same signal to two different functions and write custom logics.
NOTE please remember to add the signal connection to the new signal in already implemented projects.
Before this PR, each authorization function implemented by the Authorization module @
Firebase.Authwould emit thelogin_succeededsignal upon successful sign-up and sign-in. With this PR, two different signals will be now emitted:signup_succeededcalled upon successfulsignup_with_email_and_passwrd()andlogin_anonymous()(compliant to theidentitytoolkit#SignupNewUserResponseresponse from Firebase)login_succeededcalled upon successfullogin_with_email_and_password()andlogin_with_oauth()(compliant toidentitytoolkit#VerifyPasswordResponseandidentitytoolkit#VerifyAssertionResponseresponses from Firebase)In this way, a client-side logic to differentiate sign-up from sign-in would be easier to implement. Also, this change won't force users to change their signal connection logics: it is much more easier to connect two different signals (
login_succeededandsignup_succeeded) to the same function (example_on_login_signup_succeeded()) rather than connecting the same signal to two different functions and write custom logics.NOTE please remember to add the signal connection to the new signal in already implemented projects.