small request about cariable names

GodotVR / godot-xr-tools

Support scenes for AR and VR in Godot

MIT License

517 stars 74 forks source link

small request about cariable names #574

Open pietru2004 opened 11 months ago

pietru2004 commented 11 months ago

Please don't shadow class variable names, or when you need to do so please at least add ignore warning comment thing. I ask cause if I add multiple interactions I sometimes get like 20-40+ warnings in console about variable shadowing which is annoying and not helpfull...

Malcolmnixon commented 11 months ago

It's not our intent to shadow class variables. What are you using to find them? I'm not seeing any warnings - and we added gdlint to try and put extra protections around such bad practices.

pietru2004 commented 11 months ago

I get warnings in https://github.com/GodotVR/godot-xr-tools/blob/master/addons/godot-xr-tools/interactables/interactable_joystick.gd#L192 And https://github.com/GodotVR/godot-xr-tools/blob/master/addons/godot-xr-tools/interactables/interactable_joystick.gd#L220

About calling var position