search

GodotVR / godot_openxr

(Maintenance mode) OpenXR drivers for the Godot Game Engine v3.x
MIT License
278 stars 45 forks source link

Add workaround for swapchain release error #214

Closed mgschwan closed 1 year ago

mgschwan commented 2 years ago

Will release and reinitialize all swapchains when an error during release of a swapchain image occurs

BastiaanOlij commented 2 years ago

ping @mgschwan , Could you resolve the merge conflict and apply the requested changes? Then we can merge this in.

BastiaanOlij commented 2 years ago

@m4gr3d would like your opinion on this as well, this is a workaround, not really a fix. We have no idea what is causing the actual issue of the swapchain image not being released properly. It seems to be an issue in the Quest itself.

mgschwan commented 2 years ago

I've updated my pull request and it says there are no more conflicts.

BastiaanOlij commented 2 years ago

@mgschwan I still prefer if the relative_transform change is moved into a separate PR. This has nothing to do with fixing the swap chain and I think that one needs further discussion if we want this change.

Also want @m4gr3d feedback on the swapchain fix and see if he is ok with the workaround before we merge.

BastiaanOlij commented 1 year ago

@mgschwan I've extracted the session and swapchain fixes into separate PRs and I'm merging those. You'll need to redo a PR for the relative transform change.

BastiaanOlij commented 1 year ago

Closing as relevant fixes have been applied in other PRs.

Please open a new issue/pr if more is required.