GodotVR / godot_openxr

(Maintenance mode) OpenXR drivers for the Godot Game Engine v3.x
MIT License
278 stars 45 forks source link

Do not scale basis of transform with world scale! #215

Closed BastiaanOlij closed 2 years ago

BastiaanOlij commented 2 years ago

This is potentially a breaking change for people who are using world scale. As this was brought to my attention because it was causing issues for people doing so I think this is a safe revert.

I introduced scaling of the basis in commit 0d2ea910fdb761ea9c28eb51e78e6e6ebc0fa210, which is not what we should do here. When using world scale it is nice to apply the scaling to ensure controller meshes are scaled, but this should be applied on the controller mesh, NOT on the ARVRController node. Scaling the controller node has a lot of unwanted side effects as it adversely effects physics and as we may child a lot of things that are not expecting to be scaled (such as our teleport visualization).