search

GodotVR / godot_openxr_vendors

Godot 4 wrapper for OpenXR vendors loaders and extensions
MIT License
83 stars 17 forks source link

Retire use of the XRHandTracker::Hand #130

Closed Malcolmnixon closed 2 months ago

Malcolmnixon commented 2 months ago

When XRHandTracker was initially developed it had a Hand enum [Left=0, Right=1] identify the tracked hand.

When XR Trackers were reorganized into an inheritance-tree, XRHandTracker was modified to extend from XRPositionalTracker which already has a hand property. This resulted in duplicate information, and for C#/.Net a collision between the enum and property symbol names.

PR https://github.com/godotengine/godot/pull/91130 has been introduced to remove XRHandTracker::Hand from Godot, and this PR removes its use in godot_openxr_vendors.

UPDATE: The Godot PR has been merged removing XRHandTracker::Hand. This PR now includes the updated extension_api.json including that merge.

Malcolmnixon commented 2 months ago

This PR was an attempt to get a PR in ahead of Godot deleting XRHandTracker::Hand and with no conflicts with https://github.com/GodotVR/godot_openxr_vendors/pull/131. It wasn't going to be pretty, but would allow the repository to move forwards with Godot 4.3-dev6 compatibility, and for the hand-mesh PR to continue cleanup after rebasing.

At this point the XRHandTracker::Hand deletion has already occurred in Godot, and the team has indicated a desire for the code to be implemented cleanly; and so this PR will be deleted and the work will have to be done as part of https://github.com/GodotVR/godot_openxr_vendors/pull/131 rather than occurring extensive merge-conflicts.