search

GodotVR / godot_openxr_vendors

Godot 4 wrapper for OpenXR vendors loaders and extensions
MIT License
82 stars 17 forks source link

Create fb passthrough sample project #155

Closed devloglogan closed 1 month ago

devloglogan commented 1 month ago

Removes the fb passthrough extension material from the repos demo project and adds a new samples directory, along with a new standalone project demonstrating the passthrough functionality in both a simpler and more complete manner.

Marking this as a draft for the moment because the gradle build process isn't working perfectly yet.

devloglogan commented 1 month ago

For some reason, geometry passthrough isn't working for me with this version (whereas it was working on an earlier version I tested before the PR). When using plain "Geometry", I see nothing (the box is completely invisible). And when using "Geometry (Hole Punch)", I see a block box. I'm not sure if I've messed something on my end, but I didn't really change anything from when I tested it before.

Strange, for me the plain geometry works just fine. But now I'm noticing that hole punched geometry is a bit more noticeably "out of sync" (the opaque mesh is moving ahead of the passthrough geometry instance, so they don't line up). Zero clue what could be causing these problems right now but I'll think on it further.

Also, I still think there should be a "buffer" on the left/right side of the slider UI.

Ah, I'd added that "buffer" suggestion, but in the form that it would instead snap to the extreme ends of the slider. I've adjusted it to be more in line with your suggestion now.

devloglogan commented 1 month ago

I've updated the gradle build files and everything should now be in working condition, so I'm going to open this PR!

devloglogan commented 1 month ago

@m4gr3d That makes sense to me! I've swapped to your suggestion, adding a copyBuildToSamples task and reverting the other changes.

devloglogan commented 1 month ago

Added requested changes in latest push! Gradle confuses me a bit with the "configuration" vs "execution" phases but I was able to get the tasks working by adding doLast in both tasks, feel free to let me know if there's a better way to write that.