search

GodotVR / godot_openxr_vendors

Godot 4 wrapper for OpenXR vendors loaders and extensions
MIT License
97 stars 22 forks source link

Add API documentation for Meta's Scene Understanding and Spatial Anchor APIs #156

Closed dsnopek closed 4 months ago

dsnopek commented 4 months ago

This PR updates the XML docs from the current code (so it pulls in some stuff that wasn't present when PR https://github.com/GodotVR/godot_openxr_vendors/pull/138 was made), and adds API documentation for everything associated with Meta's Scene Understanding and Spatial Anchor APIs.

I also just realized that the bits to get the XML docs compiled into the GDExtension (so they are visible in the editor) weren't added! So, I've also taken the opportunity to update godot-cpp, and add that as well.

Logan also noticed that .\make.bat api wasn't working on Windows. So, I've snuck in a fix for that as well :-)

This will compliment the tutorial in PR https://github.com/GodotVR/godot_openxr_vendors/pull/153

m4gr3d commented 4 months ago

@dsnopek Looks like there's a build failure due to the missing Gradient type

https://github.com/GodotVR/godot_openxr_vendors/actions/runs/9261507612/job/25476985181#step:5:24

dsnopek commented 4 months ago

Hm, I'm not sure how I didn't catch that in my testing! Here's PR https://github.com/GodotVR/godot_openxr_vendors/pull/159 to fix

Even though we only update the docs site for builds on the master branch, I guess we should at least built the docs in each PR in order to detect these sort of issues..