search

GodotVR / godot_openxr_vendors

Godot 4 wrapper for OpenXR vendors loaders and extensions
MIT License
97 stars 22 forks source link

Statically link libstdc++ on Linux for portability #163

Closed goatchurchprime closed 3 months ago

goatchurchprime commented 3 months ago

This is a portability issue identified first in the webrtc libraries (since fixed) https://github.com/godotengine/webrtc-native/issues/110

image

I think all it needs are some link flags in the SConstruct file https://github.com/godotengine/webrtc-native/pull/109/commits/1de32aa9ea1f3f4e1fd3f5f9b283ac4dc2befae1

goatchurchprime commented 3 months ago

Works now if you build it from source and push the godot-cpp module up by two weeks.

goatchurchprime commented 3 months ago

This issue wasn't actually fixed.

image

It just so happened that when I built from sources the shared object was linked to a library that did exist on my disk:

image

The correct result would have been for libstdc++ not to have been an external dependency to the library, as is the case with libwebrtc:

image

dsnopek commented 3 months ago

Since this only affects desktop Linux (and not Android), I think it's probably fine to do despite the increased binary size. See PR https://github.com/GodotVR/godot_openxr_vendors/pull/166