search

GodotVR / godot_openxr_vendors

Godot 4 wrapper for OpenXR vendors loaders and extensions
MIT License
82 stars 17 forks source link

Add manifest entries for Magic Leap #178

Open BastiaanOlij opened 1 week ago

BastiaanOlij commented 1 week ago

This PR adds in manifest entries for Magic Leap 2 based on https://developer-docs.magicleap.cloud/docs/guides/openxr/getting-started/android-manifest-settings/

It's not clearly defined in the writeup here but from what I gather the hand tracking is a normal permission and doesn't require further user interaction.

The interaction can be found under the Khronos heading: image

I've not added checks in whether HTC and Magic Leap settings are both selected. There is an argument for splitting these up and creating a Khronos generic, HTC and Magic Leap AAR, we'll likely have to go down that path at some point, but so far it seems to be working.

I can't test on a Magic Leap myself but we have a user on discord who's likely able to test this for us.

m4gr3d commented 1 week ago

I've not added checks in whether HTC and Magic Leap settings are both selected.

We should include a vendor drop down under the khronos section and only show the options for the vendors that is selected.

BastiaanOlij commented 1 week ago

I've not added checks in whether HTC and Magic Leap settings are both selected.

We should include a vendor drop down under the khronos section and only show the options for the vendors that is selected.

Is that possible in that interface? That would definitely be the preferred option. It can then also have a "other" options that just exports without any platform specific flags that hopefully works on future devices

m4gr3d commented 1 week ago

I've not added checks in whether HTC and Magic Leap settings are both selected.

We should include a vendor drop down under the khronos section and only show the options for the vendors that is selected.

Is that possible in that interface? That would definitely be the preferred option. It can then also have a "other" options that just exports without any platform specific flags that hopefully works on future devices

@BastiaanOlij The second commit of https://github.com/GodotVR/godot_openxr_vendors/pull/181 showcases how to do so.

m4gr3d commented 1 week ago

@BastiaanOlij Can you update the changelog.

BastiaanOlij commented 6 days ago

@BastiaanOlij Can you update the changelog.

Done, also rebased and added an export preset for Magic Leap.

BastiaanOlij commented 4 days ago

Turns out Magic Leap is an x86_64 device, not arm :) Had to update the export preset accordingly.