GodotVR / godot_openxr_vendors

Godot 4 wrapper for OpenXR vendors loaders and extensions
MIT License
97 stars 22 forks source link

Add support for overriding non-selected Khronos vendor options #181

Closed m4gr3d closed 2 months ago

m4gr3d commented 3 months ago

This PR is broken into two commits:

BastiaanOlij commented 3 months ago

This indeed works well, though I'm guessing that once _get_export_option_visibility becomes possible that would be a better solution.

It would also be nice that if the Khronos option isn't selected, all entries related to Khronos aren't shown. The same with the other selections. But that is a nice to have.

I'm happy if we merge this as is with a note that we improve upon this when we can. I'll rebase my MagicLeap PR and add the needed changes in.

m4gr3d commented 3 months ago

I think we should merge this as it is now, and then improve it over time.

Sounds good!

@dsnopek Any thoughts on this approach?