search

GodotVR / godot_openxr_vendors

Godot 4 wrapper for OpenXR vendors loaders and extensions
MIT License
92 stars 19 forks source link

Refactor the Godot OpenXR loader to match the new Android plugin packaging format for Godot 4.2 #38

Closed m4gr3d closed 1 year ago

m4gr3d commented 1 year ago

The new format gives a lot of flexibility and allows each vendor plugin to provide its own set of parameters in the export window. Those parameters in turn influences how the Android manifest is generated.

See https://github.com/godotengine/godot/pull/78958 for reference.

BastiaanOlij commented 1 year ago

I'm guessing demo/addons/godotopenxrmeta/.gdignore is a left over from the previous setup?

Also don't we need .gdignore files in the plugin somewhere to ensure it's not exported?

m4gr3d commented 1 year ago

Note that I have bumped the version to 2.0.0 as this deprecates the previous Android packaging format and the use of the .gdap config file.

We may want to keep a 1.x branch for any bug fix we want to backport for users of the plugin on pre-4.2 version of Godot.

BastiaanOlij commented 1 year ago

Note that I have bumped the version to 2.0.0 as this deprecates the previous Android packaging format and the use of the .gdap config file.

We may want to keep a 1.x branch for any bug fix we want to backport for users of the plugin on pre-4.2 version of Godot.

I think that makes a lot of sense

m4gr3d commented 1 year ago

https://github.com/godotengine/godot/pull/78958 has been merged, so this PR should be good to go!