search

GodotVR / godot_openxr_vendors

Godot 4 wrapper for OpenXR vendors loaders and extensions
MIT License
90 stars 19 forks source link

Merge GDExtension into a single implementation #83

Closed m4gr3d closed 6 months ago

m4gr3d commented 6 months ago

Move all the gdextension logic into the common directory so to share the same functionality across all vendors.

For the editor, this enables a single scons build file and a single gdextension that can be loaded by the editor.

For Android vendor platforms, we still maintains separate cmake build files which allows to omit / include platform specific dependencies via pre-processor directives in order to generate platform specific shared libraries, which are included in platform specific AAR binaries.

Fixes https://github.com/GodotVR/godot_openxr_vendors/issues/70

dsnopek commented 6 months ago

I just built and tested this locally and it seems to be working great!

m4gr3d commented 6 months ago

I just built and tested this locally and it seems to be working great!

Thanks! I'll go ahead and merge the changes.

@BastiaanOlij Feel free to add any comments / feedback if you have any and I'll address them in a follow-up PR.