GodotVR / godot_openxr_vendors

Godot 4 wrapper for OpenXR vendors loaders and extensions
MIT License
90 stars 19 forks source link

Fix XR_FB_face_tracking on PC #85

Closed Malcolmnixon closed 6 months ago

Malcolmnixon commented 6 months ago

I didn't realize the Oculus PC app has an option to enable "Natural Facial Expressions over Oculus Link". After trying it I found a missing initialization of the XrFaceExpressionWeightsFB type field - which apparently the Android runtime didn't bother checking. Additionally this PR adds printing of the OpenXR failure result codes.

Testing on PC:

https://github.com/GodotVR/godot_openxr_vendors/assets/1863707/cd436b17-f3d1-412a-9e7d-7fd078c24562

Testing on Quest Pro Native;

https://github.com/GodotVR/godot_openxr_vendors/assets/1863707/e1346576-74fd-4a7e-84c8-32ea3b72c3ce