search

GodotVR / godot_openxr_vendors

Godot 4 wrapper for OpenXR vendors loaders and extensions
MIT License
83 stars 17 forks source link

Add .clang-format #89

Closed devloglogan closed 5 months ago

devloglogan commented 5 months ago

Since working on this repo I've just had a copy of the godot .clang-format in my project root folder locally. I figure it's worth adding this to the repo so everyone is aligned on formatting? I think I saw @BastiaanOlij mention in another PR somewhere that we should add one.

BastiaanOlij commented 5 months ago

Yes please, but also add in the CI scripts for this so it is actually checked on our PRs. That probably means also applying clang format as part of this PR.

That's going to mess people up who have PRs in flight, but its a one off pain we can better put in our past.

BastiaanOlij commented 5 months ago

@m4gr3d I don't think we should merge this until the CI changes are added and we do a clean of existing files.

m4gr3d commented 5 months ago

@m4gr3d I don't think we should merge this until the CI changes are added and we do a clean of existing files.

I missed the discussion on RC, but yes that makes sense to wait for the CI changes.