search

GodotVR / godot_openxr_vendors

Godot 4 wrapper for OpenXR vendors loaders and extensions
MIT License
99 stars 22 forks source link

Class registration issues #96

Closed BastiaanOlij closed 7 months ago

BastiaanOlij commented 7 months ago

Probably pretty harmless, and at least one should be resolved by recent pending changes from Malcolm, but we get some error spam at start up:

Cannot get class 'OpenXRFbSceneCaptureExtensionWrapper'.
Cannot get class 'OpenXRFbSpatialEntityExtensionWrapper'.
Cannot get class 'OpenXRFbSpatialEntityQueryExtensionWrapper'.
Cannot get class 'OpenXRFbSpatialEntityContainerExtensionWrapper'.
Cannot get class 'OpenXRFbSceneExtensionWrapper'.
Cannot get class 'OpenXRFbFaceTrackingExtensionWrapper'.

On a broader spectrum we should discuss about whether extensions should be exposed 1:1 as singletons, or whether we should always add nodes/resources that users can use that expose the functionality. I'm a fan of the later option and do not believe the wrappers should be exposed in this way.

BastiaanOlij commented 7 months ago

Thinking this through, the problem I wager is that these classes are only available on Quest/Android thus on PC we're getting complaints.

We need these classes to also exist on PC, if only so the IDE is aware of them and has access to them

BastiaanOlij commented 7 months ago

Ok, resolved after a restart, interesting..