search

Godson777 / KekBotSharp

KekBot, written in C#
GNU General Public License v3.0
4 stars 1 forks source link

Slashify the weeb.sh commands #106

Closed tech6hutch closed 3 years ago

tech6hutch commented 3 years ago

I converted the weeb.sh commands to slash commands. The commands are in two groups, "interact" (for commands that require a second user) and "react" (for ones that don't).

Since the arguments to a slash command don't really exist as a message, user arguments don't automatically ping them anymore, so I changed the response to use real mentions instead of nicknames and I moved it from the embed title to the message content, so it will actually ping them.

todo[bot] commented 3 years ago

Move `discord` command from meme category to weeb category?

Either way, it's just a weeb.sh command but with a different category. Dunno what to do about this one.

https://github.com/Godson777/KekBotSharp/blob/7a055b7d11e4d80b55765af1be567cd3fd24abf6/KekBot/Commands/WeebCommands.cs#L217-L222

This comment was generated by todo based on a todo comment in 7a055b7d11e4d80b55765af1be567cd3fd24abf6 in #106. cc @Godson777.
tech6hutch commented 3 years ago

Yeah that todo was in the original code I had written. I assume it's accurate.

Godson777 commented 3 years ago

Actually, because of the way you rewrote the handler for WeebCommands, wouldn't it be possible to refer to the WeebCommandsBase singleton from other classes too? Would make it possible to bring back some meme related commands like "delet this" and the "discord" command without labelling them as "weeb" commands.

tech6hutch commented 3 years ago

Yep definitely could, just use the dependency injection in any class that needs it

todo[bot] commented 3 years ago

Move `discord` command from meme category to weeb category?

Either way, it's just a weeb.sh command but with a different category. Dunno what to do about this one.

https://github.com/Godson777/KekBotSharp/blob/7739fffc89ab21ec7422e5ae6ce062ac901ef538/KekBot/Commands/WeebCommands.cs#L217-L222

This comment was generated by todo based on a todo comment in 7739fffc89ab21ec7422e5ae6ce062ac901ef538 in #106. cc @Godson777.
tech6hutch commented 3 years ago

yeah I get it, shut up lmao

tech6hutch commented 3 years ago

You know, I was thinking. /weeb solo awoo and /weeb interact hug @Godson777 are a little long. Maybe we should drop the weeb part. /interact hug @Godson777 sounds reasonable to me, but maybe solo could be renamed react or something.