Godzil / Crunchy

Crunchy is capable of downloading anime episodes from the popular CrunchyRoll streaming service.
MIT License
95 stars 19 forks source link

Long titles, maybe special characters cause issue. #26

Closed Ganabei closed 6 years ago

Ganabei commented 7 years ago

It seems either long titles or maybe colons/special characters prevent fetching of data. Noticed it when I was trying to grab 'WorldEnd: What do you do at the end of the world? Are you Busy? Will you Save us?' but it just hangs on 'Checking availability' after the Premium message, no error code or anything. I was able to get around it by putting a -s 1 into the command line which ended up giving it a blank title. Episodes are listed as '- s1e1' and '- s1e2' Folder was just called '1'. Saw someone else had an issue with Re:Zero, which is what made me think it might be the colon and how names are fetched and put into files.

Godzil commented 7 years ago

That's interesting, I will check, I know of only one character that fail (but not directly on crunchy side unfortunately) the @ symbol is redacted as if it was to remove an email from the page by something before I retrieve the page and it screw the thing. It happen on "THE IDOLM@STER CINDERELLA GIRLS" for example..

jp1995 commented 7 years ago

Can confirm this is an issue, just happened to me trying to download Problem Children are Coming from Another World, aren't they?. OP's workaround works for me too.

Godzil commented 7 years ago

There is no issues as far as I know with Re:Zero. There were an issue long time ago, but characters like ":" are correctly managed now. Maybe the "?" is the culprit there. I will check.

Oh, on which OS are you running Crunchy? because some characters are forbidden on one and not on another...

Ganabei commented 7 years ago

I'm on windows, and they don't allow ? in file names. Imagine that's what the other poster is having issues with as well.

Also, I just realized the -s modifier was for the series title, not for the series number. So just changed my command line to -s WorldEnd and called it good. Works fine for me now.

Godzil commented 7 years ago

Hummm yes I think you are right "?" are allowed under Linux/Mac OS X, but probably not under windows. I will put that in the list of characters that have to be replace

Ganabei commented 7 years ago

Windows loves their restrictions. These are the characters Windows doesn't allow \ / : * ? " < > |

Godzil commented 6 years ago

Will close that issue as I think there is no problem anymore. Please don't hesitate to reopen if some other character cause a problem