Godzil / Crunchy

Crunchy is capable of downloading anime episodes from the popular CrunchyRoll streaming service.
MIT License
95 stars 19 forks source link

index callback gives null error #70

Closed polyDog closed 6 years ago

polyDog commented 6 years ago

crunchy has worked great for a long time -- really nice tool - thank you!

Describe the bug a week or two after May 26th have consistently run into this. crunchy no longer runs. looks like a null was encountered trying to read a property 'stack'

Expected behavior proceed to fetch episode(s)

Screenshots screenshot added

Please fill theses informations:

++++++++++++++++++++++++++++++++++++++++++++++++ F:\content\crunchy>crunchy http://www.crunchyroll.com/hundred

TypeError: Cannot read property 'stack' of null at C:\Users\w\AppData\Roaming\npm\node_modules\crunchy\dist\batch.js:50:43 at C:\Users\w\AppData\Roaming\npm\node_modules\crunchy\dist\series.js:37:24 at C:\Users\w\AppData\Roaming\npm\node_modules\crunchy\dist\series.js:138:24 at C:\Users\w\AppData\Roaming\npm\node_modules\crunchy\dist\my_request.js:69:24 at Request._callback (C:\Users\w\AppData\Roaming\npm\node_modules\crunchy\node_modules\cloudscraper\index.js:90:14) at self.callback (C:\Users\w\AppData\Roaming\npm\node_modules\crunchy\node_modules\request\request.js:185:22) at emitOne (events.js:116:13) at Request.emit (events.js:211:7) at Request.onRequestError (C:\Users\w\AppData\Roaming\npm\node_modules\crunchy\node_modules\request\request.js:877:8) at emitOne (events.js:116:13) at ClientRequest.emit (events.js:211:7) at Socket.socketOnEnd (_http_client.js:423:9) at emitNone (events.js:111:20) at Socket.emit (events.js:208:7) at endReadableNT (_stream_readable.js:1064:12) at _combinedTickCallback (internal/process/next_tick.js:138:11) at process._tickCallback (internal/process/next_tick.js:180:9) ++++++++++++++++++++++++++++++++++++++++++++++++

Additional context

crunchy01

Godzil commented 6 years ago

Ok there is a bug in Crunchy when it try to display the real error, I do have a fix fox it but haven't release a new version, was not expecting someone to run on it that soon.

I will push it and try on my side to see if I get error with that anime, and if you have still the same error, please give me the new error displayed.

(Do you know which episode is failing?)

Sorry for the inconvenience

polyDog commented 6 years ago

no inconvenience here expressed or implied :)

multiple titles tested with specific episodes and/or just the general page start page -- seems to give the same result.

in this case was just 'crunchy http://www.crunchyroll.com/hundred' which was picked at random. this command should be pulling the 1st one by default if I understand correctly

will watch here when I should test --- would just be updating via npm right?

(also I've never contributed before -- how does one get involved? Is there any way to communicate privately?)

Godzil commented 6 years ago

Yes I've updated on npm yesterday, please try to update and tell me what it return, it, at least, should not crash anymore šŸ¤ž

polyDog commented 6 years ago

OK no crash! -- here is what was returned:

image

Godzil commented 6 years ago

Oh crap... why this thing is so useless....

But ok it seems that it is not able to list episodes from that series.

Can you please confirm that you see them on CR? Does you CR is in English?

polyDog commented 6 years ago

Yes can see them when visiting CR from a browser (screenshot below) Yes English episode names

Series that used to work before via Crunchy also give the same error.

Am on a tight deadline for a project at the moment or I would setup and try to debug this. I have done a bit of node/js and it would be fun to figure this out.

Is there any way for you and I to communicate privately? Or is open forum the only way?

Pic from browser: hundred

polyDog commented 6 years ago

update:

tested w/VPN to different area -- same problem still exists. tested on new Ubuntu image --- same problem still exists.

Godzil commented 6 years ago

There must be something that make Crunchy unable to parse the page, I don't understand it works fine here (ans probably for lots of other peoples..)

Do you get any more meaningful error with the 1.3.4 ?

If no, I've added un 1.3.4 a new command line parameter ( --debug ) that will dump some information in a debug.txt file in the current folder. Could you please run crunchy with that added parameter, and check in the file that no personal information (email/password) are visible in here, then attach it to this issue? That would be really helpful.

polyDog commented 6 years ago

Ah OK -- I wish I knew how I assist you better in triage! -- here is some more info:

output from console below -- output from debug attached ++++++++++++++++++++++++++++++++++++++

Godzil commented 6 years ago

Ok, could you please run again with 1.3.5 and send the debug.txt file (you can zip it as it may be big) to

crunchy-debug at godzil dot net

Please add your github username in the email title

Thanks

You can attach here too, but I can't guaranty that it may not contain some personal information (login/password should not appear but as there are dump of CR pages; I can't guaranty on what they will contain.)

polyDog commented 6 years ago

updated --- aaaand... 1.3.6 ran with no errors --- latest changes must have fixed

Godzil commented 6 years ago

Uhhhhhh???!!!!! šŸ˜…šŸ˜…šŸ˜…šŸ˜…

At least a good thing, Iā€™m closing then, feel free to reopen or create a new issue of problem appear again.