Godzil / Crunchy

Crunchy is capable of downloading anime episodes from the popular CrunchyRoll streaming service.
MIT License
95 stars 19 forks source link

Error on specific episode #79

Open xXxBobDolexXx opened 5 years ago

xXxBobDolexXx commented 5 years ago

Describe the bug The tool downloads fine until it reaches episode 9 of this series: http://www.crunchyroll.com/no-game-no-life

Expected behavior Finish downloading the series

Screenshots If applicable, add screenshots to help explain your problem.

Please fill theses informations: (Add a X between brackets to make them ticked if relevant)

Additional context Using the episode filter you added in 1.3.5 to start from episode 10 works fine when I add "-e 10-" to the command. Issue seems narrowed down to episode 9 only.

debug has been scrubbed of identifying information and posted here https://hastebin.com/vifizutobu.bash

Godzil commented 5 years ago

I didn't really need the debug file, it does not help for such issues.

I suspect this is related to #65.

If you run with --verbose, or easier, run mkvmerge by hand you should get the proper error.

Edit: Well it is not exactly the same problem (not a timing issue in the subtitles) but it is linked with the SRT format; ASS format does not have this issue.

Why are you using the SRT format? CR subtitles are clearly derived from the ASS format; and they use its ability.

It is not really crunchy fault here, as their subtitles have some newline in the text; it would need to do some major changes in the SRT exporter, and I dont have the time for it right now.