Godzil / Crunchy

Crunchy is capable of downloading anime episodes from the popular CrunchyRoll streaming service.
MIT License
95 stars 19 forks source link

Cannot Download Episodes With Newest Version (1.3.7) Edit: Maybe Solved? Wifi Issue #82

Closed barthole closed 6 years ago

barthole commented 6 years ago

Description of bug: Seems to be that Crunchy version 1.3.7 is broken on some linux systems (at least Fedora). Tried to download episodes at different times both today and the day before but the same issue persists so it doesn't seem to be a problem with CR. Any time I try to download episodes I get the same output error in the terminal. Happens on any series I try as well. Confirmed error on Overlord, Re_ZERO, Fairytail, and Darling in the Franxx. Regardless if I batch download or try to download specific episodes. Has no problem downloading the subtitle tracks, but seems to have difficulties with video. Weird, because the first time I used 1.3.7 the first episode I downloaded (Re_ZERO ep. 5) was successful and worked without a hitch.

Expected Behavior: Expected to be able to use crunchy as the awesome tool that it is. Expected to be on an anime binge in my room that doesn't have Wi-Fi, but oh well. If someone knows how to regress to the previous version of crunchy, it'd be worth looking at to see if the issue is also in 1.3.6.

Screenshots Screenshot of error: bug Not sure it's entirely necessary, but since this problem is probably linux specific, I figured a neofetch screenshot might have some info that would be beneficial brian bash konsole -3- _027

Please fill theses informations: (Add a X between brackets to make them ticked if relevant)

[brian@brianlaptop HerpDerpImAHDD]$ crunchy -u -p -r 720 --retry 10 http://www.crunchyroll.com/overlord

TypeError: Cannot read property 'syscall' of undefined at /usr/lib/node_modules/crunchy/dist/series.js:54:37 at /usr/lib/node_modules/crunchy/dist/series.js:117:20 at /usr/lib/node_modules/crunchy/dist/episode.js:98:32 at ChildProcess.exithandler (child_process.js:282:5) at emitTwo (events.js:126:13) at ChildProcess.emit (events.js:214:7) at maybeClose (internal/child_process.js:925:16) at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)

Additional Context: In the middle of me taking screenshots and making this bug report, for some reason now crunchy is working for the first time in ~72 hours on my laptop and downloading multiple episodes. I did nothing different. It was the exact same command (crunchy -u -p -r 720 --retry 10 -e 6- http://www.crunchyroll.com/rezero-starting-life-in-another-world-) and I can confirm that in another terminal I just got the exact same error message again. Maybe it could be the fact that I'm on a public network? (McDonald's Wi-Fi) I have no words. I've never experienced anything like this in my life.

barthole commented 6 years ago

Update: Walked down the street to an AT&T store that offers free public wifi. Ran the exact same command (crunchy -u -p -r 720 --retry 10 -e 6- http://www.crunchyroll.com/rezero-starting-life-in-another-world-) and now the third episode in a row is downloading now. Makes me think that the issue isn't so much with the program or Fedora, but maybe just the Wi-Fi? If that's the case then I think that is absolutely bizarre, but oh well. For now (???) the issue seems to be fixed. Leaving the post up for visibility but if anyone wants me to take it down, just let me know.

Godzil commented 6 years ago

Well there is a real bug that I already fixed in the error management that will be in the next release, but it is not linked with the fact there is an error at first.

barthole commented 6 years ago

My guess is that the error is only surfacing because of McDonald's internet policy. Somewhere along the line MD's Wifi is most likely refusing some connections to CR or delaying it to the point where crunchy is unusable. I've had no issues on AT&T's network which is also slower overall (~10 Mbit/s vs MD's 30Mbit/s). Then again there is no concrete evidence for this hypothesis beyond the fact that 1.3.7 works fine on AT&T's network but seems to just break on MD's network.