Godzil / Crunchy

Crunchy is capable of downloading anime episodes from the popular CrunchyRoll streaming service.
MIT License
95 stars 19 forks source link

Personal information in downloaded .ass format subtitles #98

Closed xXxBobDolexXx closed 6 years ago

xXxBobDolexXx commented 6 years ago

Describe the bug A clear and concise description of what the bug is. When opening .ass subtitles in notepad, it shows the account the subtitles were downloaded with .srt subtitles do not have this problem.

Not sure how difficult it is to implement but a solution could be to remove line 2 from the .ass files before merging.

Expected behavior A clear and concise description of what you expected to happen. no personally identifying information in the downloaded files. Screenshots If applicable, add screenshots to help explain your problem. http://images2.imagebam.com/4f/4e/7a/611b3d1012998084.PNG Please fill theses informations: (Add a X between brackets to make them ticked if relevant)

Please be careful to remove your real account login and password if they appear!

Additional context Add any other context about the problem here.

Also don't hesitate to add labels you feel apropriate on your report. Please don't edit logs if you are adding them, apart from removing sensitive informations like login/password

Godzil commented 6 years ago

What is the problem with that?

Apart if you are sharing the file illegally, I don’t see the point.

So no sorry no plan do do such a thing. This app try to be as clean as possible, nhave to be use as close as possible to fair rights, and sharing the downloaded files are not part of that.

So give me a good reason which is NOT sharing, and I may consider.

Up so far I’m closing this as not a bug.