Godzil / theunarchiver

Automatically exported from code.google.com/p/theunarchiver
Other
0 stars 0 forks source link

Unarchiving LhA archives with file comments appends comments to filenames #660

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
AmigaDOS allowed the attachment of an 80 character comment string to files, and 
LhA archives created on the Amiga include the comment in the filename array, 
separated with a NULL byte. The Unarchiver 3.7 appends the comment to the 
filename with a space, as opposed to commandline lha which silently discards 
the comment. I have attached cfd.lha which has comments attached to every 
filename, and here's a dump of the first file's header:

  .byte $57                                     ; Header length
  .byte $ba                                     ; Header checksum
  .byte $2d,$6c,$68,$35,$2d                     ; "-lh5-"
  .dword $00000550                              ; Compressed size
  .dword $0000069e                              ; Original size
  .dword $2c9383c4                              ; Date stamp
  .word $0000                                   ; Attributes/header level
  .byte $41                                     ; Pathname length
  .byte $63,$66,$64,$2e,$69,$6e,$66,$6f         ; "cfd.info"
  .byte $00                                     ; NULL
  .byte $45,$72,$73,$74,$65,$6c,$6c,$74,$20,$31 ; "Erstellt 1"
  .byte $39,$2e,$30,$34,$2e,$32,$30,$30,$32,$20 ; "9.04.2002 "
  .byte $31,$35,$3a,$35,$31,$3a,$31,$37,$2c,$20 ; "15:51:17, "
  .byte $6c,$65,$74,$7a,$74,$65,$72,$20,$5a,$75 ; "letzter Zu"
  .byte $67,$72,$69,$66,$66,$20,$30,$34,$2e,$30 ; "griff 04.0"
  .byte $32,$2e,$32,$30,$30,$39                 ; "2.2009"
  .word $8308                                   ; CRC16

Original issue reported on code.google.com by MagerV...@gmail.com on 25 Apr 2013 at 1:30

Attachments:

GoogleCodeExporter commented 8 years ago
Fixed. Comments are now added as metadata.

Original comment by paracel...@gmail.com on 12 Jun 2013 at 12:27