search

Gofake1 / Nightlight

Browse the internet more comfortably at night
https://gofake1.net/projects/nightlight.html
MIT License
89 stars 9 forks source link

GitHub dark mode doesn't look very good #1

Closed ajkblue closed 7 years ago

ajkblue commented 7 years ago

When dark mode is enabled on GitHub the website doesn't look very good and some text is difficult to read. Do you plan on adding any custom stylesheets for certain websites or do they all use the same general ruleset? But as an aside, I've been looking for an app like this for a long time, and am excited to see how this matures!

Gofake1 commented 7 years ago

I personally use Stylish for Github instead of Nightlight. There is also an unavoidable inefficiency due to Nightlight having to walk the entire DOM tree, which you can notice on any webpage with a lot of elements (such as a long Github source code page), so that's another point in favor of Stylish.

That being said, can you can post a screenshot of the offending page(s)? I realize that you might not want to use another extension as a workaround.

ajkblue commented 7 years ago

Yeah, I'm kinda hoping not having to install more extensions than I already have. But here are a few examples, being a projects' homepage (description and buttons are difficult to read) as well as issue pages have funny white lines everywhere. darkmode darkmode2

ajkblue commented 7 years ago

Also, I don't know if this needs to be opened as a separate issue, but the automatic night mode feature doesn't seem to be working right

Gofake1 commented 7 years ago

Did you recently update Nightlight? You'll need to refresh the page after updating. If that isn't the case, wait for a day and see if it still doesn't work.

ajkblue commented 7 years ago

Yes I have, I just barely got version 0.1.2 late yesterday I believe. I'll do further testing to verify this issue though, and get back with you.

ajkblue commented 7 years ago

After using this for a few days, it doesn't seem like the automatic feature to turn nightlight on and off isn't working. I have it set to turn on at 22:00 and off at 8:00, yet it never does. I still have to manually click on the button in the menu bar to turn it off and on everyday. Is there something I'm missing or something that's not working right here?

Gofake1 commented 7 years ago

Just to make sure, did you tick the "Automatic" checkbox? Did you also restart Safari? That usually fixes the problem for me. Otherwise I don't know how to reproduce the issue.

ajkblue commented 7 years ago

After doing a restart and cleaning the cache, the automatic switching seems to be working now. This issue can be closed unless there's something you're able to do to make GitHub a little more legible

Gofake1 commented 7 years ago

I'm working on something called Aggressive Mode that should improve Github's appearance.

Gofake1 commented 7 years ago

v0.1.4 was accepted by Apple today; it contains Aggressive Mode, which fixes the appearance of the Github buttons.

ajkblue commented 7 years ago

It looks good to me! Thank you so much for making this, I've been looking for something like this for Safari for years