Open GeekyPeas opened 2 years ago
You are absolutely right, and I apologize for not responding earlier. It was very difficult to do so before due to the disorganization in the repository and themes.
Now, with the adjustments that have been made, I believe it will be much easier.
This JSON file has all the themes organized and standardized, so many things can be done from it and all the necessary tests can be run to achieve this.
I agree that this is of great importance, and in fact, I want to create ratings for each theme related to this matter and add the results to the website for each theme.
For now, I can't promise that I'll be able to do it myself, but I'll be keeping a close eye on it and try to find time to work on it.
As always, pull requests are more than welcome.
Ref:
These tests were run in comparison with the background
![Screen Shot 2023-02-28 at 09 59 00-fullpage](https://user-images.githubusercontent.com/2009698/221892119-bf9c76c3-e570-408d-9ad4-360d75afb360.png)
Discussed in https://github.com/Gogh-Co/Gogh/discussions/60
================================
In many of the themes the problem is that
COLOR_1
is same as/ similar toBACKGROUND_COLOR
. I don't see any design philosophy/ policy for this project. I wish to suggest the following design rule, that:This should completely eliminate all readability issue.
Originally posted by @GeekyPeas in https://github.com/Gogh-Co/Gogh/discussions/60#discussioncomment-3497858
================================
I suggest we should run each
color
(that isCOLOR_1
,COLOR_2
etc.) against theBACKGROUND_COLOR
via the following method in a stackoverflow answer on "Given a background color, how to get a foreground color that makes it readable on that background color?".So according to the World Wide Web Consortium’s (W3C) Web Content Accessibility Guidelines 2.0 we must have:
contrast ratio of at least 4.5:1 for regular text (12 pt or smaller), and
contrast ratio of at least 3.0:1 for large text
Then for every
(color, BACKGROUND_COLOR)
pair that fails the test, we must replace thecolor
.Originally posted by @GeekyPeas in https://github.com/Gogh-Co/Gogh/discussions/60#discussioncomment-3498425