Gogh-Co / Gogh

Gogh is a collection of color schemes for various terminal emulators, including Gnome Terminal, Pantheon Terminal, Tilix, and XFCE4 Terminal also compatible with iTerm on macOS.
https://gogh-co.github.io/Gogh/
MIT License
9.22k stars 584 forks source link

Alacritty: Switch to toml config #415

Open UltraBlackLinux opened 9 months ago

UltraBlackLinux commented 9 months ago

Alacritty recently deprecated their yml config and switched to toml. Gogh does not yet seem to be aware of this and doesn't change the colorscheme properly. Are you able to fix that? Thanks!

asalois commented 4 months ago

If you remove the alacritty.yml file from ~/.config/alacritty/ does Gogh still not set the theme?

UltraBlackLinux commented 4 months ago

If you remove the alacritty.yml file from ~/.config/alacritty/ does Gogh still not set the theme?

I have already done so expecting that to be the issue, but no dice.

Here's the error I'm getting:

Could not find existing 'colors' settings in your alacritty.yml file
please make sure to uncomment
'colors', as well as 'primary', 'normal' and 'bright'
Check the example config at
https://github.com/alacritty/alacritty/releases/download/v0.12.2/alacritty.yml for more information
Note that alacritty following release 0.13.0 uses toml configuration.
asalois commented 4 months ago

Do you have section that looks like below in ~/.config/alacritty.toml ? I believe you will need to have the colors section in that file in order for Gogh to be able to update the colors.

[colors.primary]
background = "#15141b"
foreground = "#edecee"

[colors.cursor]
cursor = "#a277ff"

[colors.selection]
text = "CellForeground"
background = "#29263c"

[colors.normal]
black = "#110f18"
red = "#ff6767"
green = "#61ffca"
yellow = "#ffca85"
blue = "#a277ff"
magenta = "#a277ff"
cyan = "#61ffca"
white = "#edecee"

[colors.bright]
black = "#4d4d4d"
red = "#ff6767"
green = "#61ffca"
yellow = "#ffca85"
blue = "#a277ff"
magenta = "#a277ff"
cyan = "#61ffca"
white = "#edecee"

This came from https://github.com/alacritty/alacritty-theme/blob/master/themes/aura.toml BTW

asalois commented 4 months ago

You also may want to look at https://github.com/Gogh-Co/Gogh/issues/304 and see if that helps too.

UltraBlackLinux commented 4 months ago

that worked, thank you so much!

Now I'm wondering - why does it check at all? If I want a theme I know that before I run gogh, I don't think gogh should that check itself.

Lauel09 commented 1 month ago

Now I'm wondering - why does it check at all? If I want a theme I know that before I run gogh, I don't think gogh should that check itself.

+1. Really confused too. For example I am setting up my xubuntu, and alacritty on it ( I have no previous config), but it wanted me to fill these values. Which I thought was pretty bizarre. Maybe intentional.