search

Gogh-Co / Gogh

Gogh is a collection of color schemes for various terminal emulators, including Gnome Terminal, Pantheon Terminal, Tilix, and XFCE4 Terminal also compatible with iTerm on macOS.
https://gogh-co.github.io/Gogh/
MIT License
9.23k stars 586 forks source link

apply-colors.sh has a bug #450

Closed bwanshoom closed 3 months ago

bwanshoom commented 3 months ago

Line 126 is currently this: if [[ -z "${GS}"]] &&[[ -z "${DCONF}" ]] && [[ -z "${GCONF}" ]]; then

it should be this: if [[ -z "${GS}" ]] && [[ -z "${DCONF}" ]] && [[ -z "${GCONF}" ]]; then

It's missing a couple spaces

luX0r-reload commented 3 months ago

Yes, Yesterday update break apply script.

On my Ubuntu workstation with gnome terminal:

/tmp/gogh.apply.EEXYdO: line 126: conditional binary operator expected
/tmp/gogh.apply.EEXYdO: line 126: syntax error near `-z'
/tmp/gogh.apply.EEXYdO: line 126: `        if [[ -z "${GS}"]] &&[[ -z "${DCONF}" ]] && [[ -z "${GCONF}" ]]; then'
EvergreenTheTree commented 3 months ago

Fixed in #449, should be closed.