search

Gogo1951 / Groupie

A better LFG tool for Classic WoW.
MIT License
2 stars 3 forks source link

TacoTip Breaks Groupie #229

Closed Gogo1951 closed 1 year ago

Gogo1951 commented 1 year ago

image

Thread : https://discord.com/channels/1009139814836207656/1009141205629669457/1043645240080339074

When TacoTip maxes out the API calls, we can't get the data we need and it breaks.

I don't know what the answer is, but I know that add-on gives me massive lag spikes and makes more API calls than anyone should be comfortable making. Likely the only fix is going to be reaching out and re-writing his add-on for him. Guessing if he knew how, he would have done it already. Oof.

Any ideas?

My guess is we should do a check... and if we don't know what the Player's GearScore is, just default back to "Level 80..."

TannerShmoog commented 1 year ago

Yea currently there is already a nil check to prevent the message from breaking entirely in this case, I can make it default to level instead of omitting the phrase if we cant get it. Strange that tacotip is preventing us from getting data for ourselves though. I take it you had the guy turn it off and it started working?

TannerShmoog commented 1 year ago

As for moving it as the guy mentioned, I can add an X and Y slider for the location

Gogo1951 commented 1 year ago

I don't see a valid use case for moving it.

TannerShmoog commented 1 year ago

I think I see the issue with messages not working, as they should work regardless of tacotip.

I don't see a valid use case for moving it.

Dont have to add it if you dont want, but if its overlapping text from other addons then that seems reasonable

Gogo1951 commented 1 year ago

Ours won't overlap, unless someone else did their tooltips stupid. The solution is not to also do the tooltips stupid. (=

TannerShmoog commented 1 year ago

I mean in the character sheet, not the tooltip. nothing we can do about that without knowing the names of the frames that every addon uses

TannerShmoog commented 1 year ago

tooltips work fine, and swapping the order is useless yea

Gogo1951 commented 1 year ago

I mean in the character sheet, not the tooltip. nothing we can do about that without knowing the names of the frames that every addon uses

Got it. You can turn the stuff off in the Character Sheet. I think that's sufficient.

TannerShmoog commented 1 year ago

1e9e236ddf5d928ac14ed073b4cd55234a2246b6 The OP issue should be fixed here.