Library updates, include FlameLeviathan bonus itemlevels + Herald Check in character sheet

[Road-block]

As seen on the commit list for this pull request it already includes the work done in develop branch by Tanner up to this point.

Additions on top of that include

• using the computed averageitemlevel and cache of libgearscore and only falling back to groupie own ilvl/cache implementation if that's not available for some reason
• adding flameleviathan (vehiclescore) and herald check to character sheet and adjusting appearance
• adding a tooltip that shows on mouseover what message the LFG button will send if pressed.

[Gogo1951]

Let's do this without the Tooltip changes. The {rt3} Looks ugly in the tooltip. Nobody should ever see that written that way. @TannerShmoog @Road-block

[Gogo1951]

Also what is the "Leviathan 91" I don't get the 91 part.

Let's leave Levithan and Herald out... seems like something that's better left to weak auras.

[Road-block]

91 is the itemlevels above baseline for vehicles. The players that care about optimizing for vehicle encounters (like Flame Leviathan) will know what it represents. 😄 Alternatively the library also can provide a percentage increase (in vehicle health or ability damage) which might be more user friendly.

[Road-block]

About the tooltip hint. Personally I don't like user elements that are opaque in function, ie I can only understand what they do after I already used them. The target charm escape sequence can be stripped if that's the problem, but I don't think [LFG] lets the player know what the button does. [Respond] / [Reply] ? I could guess this button will send a message if that was the label. [LFG] tells me nothing about what it does.

The first time I hit it I thought it was going to do a C_PartyInfo.RequestInviteFromUnit()

[Road-block]

I am just explaining the motivation btw, I'm fine with cherry picking anything that aligns with the design and leaving other stuff out 👍🏻

[Road-block]

Does this make more sense for the vehicle? "Forgot to equip pants" No longer being pants

That's how people are going to use it to optimize their kit for vehicles.

[Gogo1951]

It's fine, you're probably the last person left using this. Might as well get what you want. (=

Beggars can't be choosers. There's stuff I wouldn't agree with, but at the end of the day however it gets done, it gets done. I'm not helping this add-on sticking around.

[Gogo1951]

% are better. And it's all vehicles, so better to say "vehicle" vs leviathan. So like drakes in Occ, and Eye. Yeah?

[Road-block]

% are better. And it's all vehicles, so better to say "vehicle" vs leviathan. So like drakes in Occ, and Eye. Yeah?

Mostly correct and yes I had my internal dialog about "Vehicles:" instead of Leviathan. It's more future proof.

Would this be more acceptable as a tooltip hint? (color coded by the chattype and with marker placeholders stripped.

Again I'm fine with this being left out, I interpreted the critique as "it's ugly" not "it's useless" 😝