search

Goh-Li-Ting / pe

0 stars 0 forks source link

find NRIC can take in more than one NRIC #12

Open Goh-Li-Ting opened 1 year ago

Goh-Li-Ting commented 1 year ago

find S1111111Z S1111112Z still works to find the first NRIC but UG states that it can only take in one NRIC which implies that S1111111Z S1111112Z is one NRIC so UG is misleading.

image.png

nus-se-bot commented 12 months ago

Team's Response

Our UG states that find by NRIC only works for a single person. Therefore this is considered an extreme case and not really relevant.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While I am unable to find where in the UG was it stated that "find by NRIC only works for a single person" other than how person is used instead of persons, I would expect find S1111111Z S1111112Z to show an empty list if find by NRIC only works for a single person.

image.png

This is because according to the UG, "Extraneous parameters behind any valid parameters will be deemed as the input for that parameter." so I would expect S1111111Z S1111112Z to be deemed as the input for NRIC, and since there are no persons with the NRIC S1111111Z S1111112Z, I would expect no persons to be found based on what the UG mentioned.

image.png

Furthermore, if a user inputted find S1111111Z S1111112Z, the user may have misunderstood the command to work similarly to Locating persons by name and seeing find S1111111Z S1111112Z produce a list with one person with NRIC S1111111Z may lead them to believe that there is no person with the NRIC S1111112Z.

I feel that the application's intended behaviour is correct, so I believe that this is a documentation bug as it was not clearly documented that extraneous parameters would be ignored, instead of being "deemed as the input for that parameter".