Goh-Li-Ting / pe

0 stars 0 forks source link

Sequence diagram lifeline end should have a disclaimer #17

Open Goh-Li-Ting opened 1 year ago

Goh-Li-Ting commented 1 year ago

Should include a disclaimer that due to the limitations of plantUML, the lifeline continues even after the X for all sequence diagrams that has a X.

image.png

soc-se-bot commented 12 months ago

Team's Response

The limitation has already been mentioned before. Since the diagrams are all similar, it is clear that they are all drawn using PlantUML, hence it is clear that they all have this same limitation and there should not be more repetition mentioning this.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While it is true that the limitation is the same and readers should infer that there is this limitation for the diagrams, the disclaimer is specific for DeleteCommandParser. This may cause some readers to question if it was intended for the lifeline to continue after the cross or they may be confused about whether the cross was accidentally placed in the diagram.

image.png

To avoid confusion for the user, there should have been a more general disclaimer that "All lifelines that have a destroy marker (X) should end at the destroy marker (X) but due to a limitation of PlantUML, the lifeline reaches the end of the diagram."