soc-pe-bot
commented
12 months ago Team's Response
The choice to make nric immutable was intentional. nric is the unique key in our system and is linked to appointments and many other commands. It makes sense that someone can't edit nric. If we allowed editing nric, it would create many new bugs. If enter wrongly there's a way to delete and re-enter.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: Suppose a user inputted an NRIC wrongly but did not realise it and created a few appointments using the wrong NRIC, such as when registering a new patient who will be coming for regular appointments that are scheduled in advance to ensure that the patient gets a slot instead of scheduling after each appointment. After realising the error in the NRIC, the user would have delete and add the patient and all the appointments (since deleting a patient does not automatically delete the associated appointments and there is also no way to edit an appointment). This poses a big hassle for the user. Furthermore, considering how the NRIC has to be unique, editing the wrong NRIC to another unique NRIC should not introduce much bugs. Therefore, I still believe that being unable to edit NRIC is a feature flaw, or should have at least been NotInScope.
I believe that it would be more suitable to allow users to change the NRIC of the users as users may input the NRIC wrongly so to change the NRIC they would have to delete and re-add the patient/doctor which is a hassle as both patients and doctors have a lot of information to input.