GokuMohandas / Made-With-ML

Learn how to design, develop, deploy and iterate on production-grade ML applications.
https://madewithml.com
MIT License
37.51k stars 5.95k forks source link

Lessons page, Basic ML: "Notebook not found". #166

Closed ColinLeongUDRI closed 4 years ago

ColinLeongUDRI commented 4 years ago

Problem: Starting from either https://practicalai.me/learn/lessons/ or https://github.com/practicalAI/practicalAI, when attempting to click any of the lessons I see "Notebook not found". Proposed fix: Possibly "basic_ml" should be added to the path?

image

When I click "authorize with Github" I see the same thing: image

The link given then does not work: image

In the case of the "linear regression" notebook, the non-working link given on the "lessons" page is https://colab.research.google.com/github/practicalAI/practicalAI/blob/master/notebooks/04_Linear_Regression.ipynb

Whereas if you go find it on github directly, it is https://colab.research.google.com/github/practicalAI/practicalAI/blob/master/notebooks/basic_ml/04_Linear_Regression.ipynb

GokuMohandas commented 4 years ago

Hey @ColinLeongUDRI , thanks for catching this mistake! I've fixed the readme and the links on the website as well https://practicalai.me

Sherlock-1 commented 4 years ago

sorry,it seemed that it still cannot be opened.....If possible,could you please solve the problem?