Open dhinogz opened 11 months ago
Thanks @MatthewJamesBoyle and @romanitalian for taking the time to review my code! I've implemented most of the changes suggested in the thread. I'll add some tests on Sunday when I have the time.
Look forward to it!
Sorry for taking so long! I had a busy week of Uni.
I added some unit tests for the validate talk function. Should I add any other tests? Open to any suggestions to get this pull request done.
No need to apologise! Thanks for the great work. Let's leave it open for a few days for folks to review. I'll review it in detail at the weekend!
Also, a screenshot as a preview would be great.
I'd say this is still a work in progress, just wanted to make sure things are going on the right path. Since I was adding database functionality, I had to make some architecture decision, which I think everyone should be ok with before moving forward.
I added:
I also didn't want to add new dependencies (like a router or a form parser) without getting an opinion from everybody else. I'd say Chi would be a good choice for a router.
Other things missing or nice to haves