search

Gold872 / elastic-dashboard

A simple and modern dashboard for FRC
MIT License
90 stars 21 forks source link

Add WPILib build #112

Closed Gold872 closed 1 month ago

Gold872 commented 1 month ago

Runs a separate build workflow for a version of Elastic with the WPILib icons and separate title

The WPILib build does not check for updates from the GitHub repository as it is installed through the WPILib installer

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.19%. Comparing base (d719f43) to head (5802b42). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/pages/dashboard_page.dart 77.77% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #112 +/- ## ========================================== + Coverage 66.15% 66.19% +0.03% ========================================== Files 77 78 +1 Lines 8014 8022 +8 ========================================== + Hits 5302 5310 +8 Misses 2712 2712 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Gold856 commented 1 month ago

In my opinion, Elastic can keep its own logo. AdvantageScope will be using its own logo for 2025.

Gold872 commented 1 month ago

For the executable icon itself, I want to use the WPILib logo so that way the 2 different distributions don't get mixed up