Gold872 / elastic-dashboard

A simple and modern dashboard for FRC
MIT License
73 stars 13 forks source link

Graph options sometimes don't set #12

Closed daltzctr closed 9 months ago

daltzctr commented 10 months ago

Looks like I have to add or remove any widget to "force" it to update it's settings.

Gold872 commented 10 months ago

Could you send a video of this happening?

daltzctr commented 10 months ago

https://github.com/Gold872/elastic-dashboard/assets/105223895/eed0d5e5-5ad2-483b-a869-460df8c4058b

Gold872 commented 10 months ago

You have to hit enter before clicking "Close". From what I know this is a limitation of Flutter so I don't think I can fix this.

daltzctr commented 10 months ago

Can there be a "confirm" or "save" button? Doesn't seem like good UX

Gold872 commented 10 months ago

I'll think about a way of doing this since it's a good idea

Gold872 commented 9 months ago

I finally figured out the solution to this. It had to do with the graph widget being a stateful widget that wasn't in a stream builder. The solution was very convoluted but the widget should now successfully rebuild when you change its settings.